Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: correct error message for invalid trailer #6308

Closed
wants to merge 1 commit into from
Closed

http: correct error message for invalid trailer #6308

wants to merge 1 commit into from

Conversation

bengl
Copy link
Member

@bengl bengl commented Apr 20, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

http

Description of change

Prevent misleading error messages when trailers are invalid.

@bengl
http: correct error message for invalid trailer
93d31c4 
Prevent misleading error messages when trailers are invalid.
@jasnell jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. error-handling http Issues or PRs related to the http subsystem. labels Apr 20, 2016
@jasnell
Copy link
Member

jasnell commented Apr 20, 2016

LGTM

2 similar comments
@addaleax
Copy link
Member

LGTM

@mscdex
Copy link
Contributor

mscdex commented Apr 20, 2016

LGTM

@estliberitas estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23
jasnell pushed a commit that referenced this pull request Apr 27, 2016
@bengl @jasnell
http: correct error message for invalid trailer
31bef6b 
Prevent misleading error messages when trailers are invalid.

PR-URL: #6308
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell
Copy link
Member

jasnell commented Apr 27, 2016

Landed in 31bef6b

@jasnell jasnell closed this Apr 27, 2016
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bengl @jasnell @addaleax @mscdex